[codex] Detach image upstream context#3365
Draft
cyeinfpro wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign, please reply with the following comment:
You only need to sign once — it will be valid for all your future contributions to this project. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
cyeinfpro
force-pushed
the
codex/detach-image-upstream-context
branch
from
88a266f to
165ddc8
Compare
cyeinfpro
force-pushed
the
codex/detach-image-upstream-context
branch
from
007c7bf to
e6dc8b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
For non-stream
/v1/images/*requests routed through API-key accounts, the upstream request reused the downstream HTTP context. If the client or an intermediate proxy disconnected before upstream image generation completed, the gateway canceled the provider request withcontext canceled. The provider may already have accepted and billed the generation, but the gateway could no longer receive the successful image response.Streaming image requests and the Responses/OAuth image path already use detached upstream contexts. This change makes API-key non-stream Images forwarding consistent with those flows.
Validation